ohmybash / oh-my-bash

A delightful community-driven framework for managing your bash configuration, and an auto-update tool so that makes it easy to keep up with the latest updates from the community.
https://ohmybash.github.io
MIT License
5.86k stars 651 forks source link

fix: Quoting #432

Closed hyperupcall closed 1 year ago

hyperupcall commented 1 year ago

Improve quoting in various areas.

I also had the chance to reproduce #242, but it seems like the issue has been fixed since then. So closes #242

akinomyoga commented 1 year ago

I was also searching the upstreams

akinomyoga commented 1 year ago

Updated commit messages for Conventional Commits.

hyperupcall commented 1 year ago

I'm not sure what other improvements I could add, but it looks good to me. It's probably not as productive to fix the completions because it is better to do so upstream - it would be nice if these sort of issues could be autofixed, but I don't think there currently exists a tool to do that (in my opinion ShellCheck doesn't do a very good job of that)