ohmybash / oh-my-bash

A delightful community-driven framework for managing your bash configuration, and an auto-update tool so that makes it easy to keep up with the latest updates from the community.
https://ohmybash.github.io
MIT License
5.54k stars 626 forks source link

lib/git: Fix problems caused by uses of Zsh features #484

Closed akinomyoga closed 8 months ago

akinomyoga commented 8 months ago

This also includes refactoring.

akinomyoga commented 8 months ago

@hyperupcall Hi, how are you doing? The GitHub Action lint (Check EditorConfig Format), which you introduced in #433, has been very helpful so far. Thank you! I'm reaching out to you because a few days ago, the action seems to have started to always produce an error. Could you take the time to look at it when you have time? It seems to be related to the Go version of the environment, but I haven't carefully examined it.

hyperupcall commented 8 months ago

Hey! I'll take a look at it tomorrow. My best guess right now is that an invalid assumption about modules was made, like in relation to GO111MODULEs.

Edit: Here is the root cause: https://github.com/editorconfig/editorconfig-core-go/commit/73c37c49c298ff5a605f2a07228f3f99acf3d2d8

akinomyoga commented 8 months ago

Thank you!