nvm plugin always add "v" for version prefix although it's not a semantic version

ohmybash / oh-my-bash

A delightful community-driven framework for managing your bash configuration, and an auto-update tool so that makes it easy to keep up with the latest updates from the community.

https://ohmybash.github.io

MIT License

5.54k stars 626 forks source link

nvm plugin always add "v" for version prefix although it's not a semantic version #504

Closed ffd114 closed 6 months ago

ffd114 commented 6 months ago

According to the nvm's docs we can put not only semantic version but also lts/* and node. In the nvm plugin, it will add prefix "v" from .nvmrc file if the first letter is not "v" which will fail to install if the .nvmrc is not semantic version like lts/hydrogen or node

akinomyoga commented 6 months ago

The upstream seems to have been changed.

https://github.com/nvm-sh/nvm/pull/2017 https://github.com/nvm-sh/nvm/commit/ff77ac17af8b45bbb76edaebbdc58827c693b7e2