search

ohmyzsh / ohmyzsh

🙃 A delightful community-driven (with 2,400+ contributors) framework for managing your zsh configuration. Includes 300+ optional plugins (rails, git, macOS, hub, docker, homebrew, node, php, python, etc), 140+ themes to spice up your morning, and an auto-update tool that makes it easy to keep up with the latest updates from the community.
https://ohmyz.sh
MIT License
174.38k stars 25.93k forks source link

fix: kube-ps1 is not on display without touch $PROMPT #11894

Closed jjangga0214 closed 1 year ago

jjangga0214 commented 1 year ago

Describe the bug

It seems kube-ps1 plugin works only when $PROMPT is manually set.

PROMPT=$PROMPT'$(kube_ps1) '

Is this the intended design?

There was an issue: https://github.com/ohmyzsh/ohmyzsh/issues/7261. And it's resolved, but the same thing happens again?

Steps to reproduce

.

Expected behavior

.

Screenshots and recordings

No response

OS / Linux distribution

macOS Ventura 13.5.2(22G91)

Zsh version

zsh 5.9 (x86_64-apple-darwin22.0)

Terminal emulator

Warp

If using WSL on Windows, which version of WSL

None

Additional context

No response

carlosala commented 1 year ago

The function needs to be added to the theme by the user. Different users might want it to be implemented differently. That PR that you mentioned was done to enable auto-disable (so that $(kube_ps1) prompts nothing) when a file exists in $HOME/.kube/kube-ps1/disabled, a file that is created executing kubeoff, and is removed executing kubeon. Modifying `$PROMPT was never in the pipeline. Thanks for the report!