search

ohnnyj / brackets-numbertabs

8 stars 2 forks source link

Reposition the counter #7

Closed a-bakos closed 7 years ago

a-bakos commented 7 years ago

Hey ohnnyj,

First of all, thanks for this little extension, I like it, speeds up the things while working.

One thing that bugged me was that the counter blocked out those visual "notifications" that appear when a file is modified, or the closing "X" icon when hovering over the filename:

problem

I changed the "left" position of the counter in the less file, so everything can fit in, and now it looks like this:

solution

What do you think?

Attila

ohnnyj commented 7 years ago

I can see what you mean and I like the idea. Only thing I would say, this would make it so the numbers no longer aline with the left margin which runs alongside the tree view.

What do you think of the following? Granted you lose a few pixels for the filename (but users can increase their sidebar width to adjust). No right answer here just throwing this out as a different option.

number-tabs
a-bakos commented 7 years ago

Thanks for your response here. :) I personally don't mind if the numbers didn't align with the tree view.

But honestly, I like your solution better, and I can easily sacrifice those few pixels.

ohnnyj commented 7 years ago

Another option, the extra whitespace between the number and icons bothered me in the previous one.

https://github.com/ohnnyj/brackets-numbertabs/pull/8

ohnnyj commented 7 years ago

@a-bakos Thanks again for this. Pushed the change in #8. Hope it works well for you.