ohnosequences / mg7

Configurable and scalable 16S metagenomics data analysis
https://goo.gl/y3rZFD
GNU Affero General Public License v3.0
3 stars 3 forks source link

Upgrade loquat dependency to refactor pipelines code #112

Closed laughedelic closed 8 years ago

laughedelic commented 8 years ago

With https://github.com/ohnosequences/loquat/pull/58 it should be possible to define pipelines in a more convenient way (see that issue description).

laughedelic commented 8 years ago

@eparejatobes review this please. The main point of this refactoring is to reduce the boilerplate code in pipeline definitions. Check the test pipelines code for examples. Now all user has to define is

Data mappings and loquat definitions are derived from this.

It is also possible to override config for each loquat and I'm in a doubt about it: probably it's better to define them always explicitly, because it's hard to set some sensible defaults for the workers group sizes. I still set them though (to the number of input samples). What do you think about it?

eparejatobes commented 8 years ago

Overall a nice improvement :+1:

I will add comments.

eparejatobes commented 8 years ago

In general in https://github.com/ohnosequences/mg7/blob/09170afb9cceddb9f8e8f00b50b888890d5ab226/src/main/scala/mg7/pipeline.scala the different components which make a config should be separated into different types.

eparejatobes commented 8 years ago

Done! also nice that now the flash part is separate :+1:

laughedelic commented 8 years ago

I think most comments are addressed. I'm moving to db.rna16s.

eparejatobes commented 8 years ago

OK fine. LGTM, the loquat part can wait.

laughedelic commented 8 years ago

Published as 1.0.0-M5-pr78-139-g91401e1