search

ohnosequences / mg7

Configurable and scalable 16S metagenomics data analysis
https://goo.gl/y3rZFD
GNU Affero General Public License v3.0
3 stars 3 forks source link

NoFlashDataflow lacks summary and stats #63

Closed eparejatobes closed 8 years ago

laughedelic commented 8 years ago

At this moment it's by design. Because then you need to have another stats loquat for the NoFlashDataflow, because it has less inputs.

eparejatobes commented 8 years ago

I didn't quite inderstand your reply. Is it, for some reason, not possible to have stats for NoFlashDataflow?

laughedelic commented 8 years ago

Well, it is, but the code for collecting stats is not flexible: it requires as inputs some outputs from the flash-step. Loquat doesn't have "optional inputs", so you can have another stats and summary steps for this type of pipeline with a lot of code duplication, but I would prefer to make it somehow better.

eparejatobes commented 8 years ago

One way or another, this should be part of the no-flash option.

laughedelic commented 8 years ago

Not arguing with this. It just wasn't planned for the next release as not urgent feature that can wait until issues causing this difficulty get resolved.

eparejatobes commented 8 years ago

Note to self: needs discussion with @rtobes @marina-manrique

laughedelic commented 8 years ago

I think we have discussed this and decided to move stats/summary to a separate project. @eparejatobes Is this correct?

eparejatobes commented 8 years ago

Yes.

laughedelic commented 8 years ago

Ok. The I'm closing this.