Closed laughedelic closed 8 years ago
As #84 was prematurely merged, here I will track unaddressed issues from there. Here are some from the https://github.com/ohnosequences/mg7/pull/84#issuecomment-235938466:
noFlash.scala:79:
4.assign.scala:57:
5.merge.scala:18:
6.count.scala:79:
I checked those that are redirected to separate issues, their progress will be tracked there. Other, mostly minor things will be done here.
As #84 was prematurely merged, here I will track unaddressed issues from there. Here are some from the https://github.com/ohnosequences/mg7/pull/84#issuecomment-235938466:
noFlash.scala:79:TODO factor this into a (private) method, same for listing objects etc (see #96)4.assign.scala:57:TODO this is too big. Factor BBH and LCA into methods (see #97)5.merge.scala:18:TODO no default arguments please6.count.scala:79:TODO create a local case class or record for the return type (see #98)I checked those that are redirected to separate issues, their progress will be tracked there. Other, mostly minor things will be done here.