ohnosequences / nice-sbt-settings

sbt plugin with common settings for all era7/ohnosequences releases
GNU Affero General Public License v3.0
10 stars 2 forks source link

Add Scalafmt #59

Open laughedelic opened 7 years ago

laughedelic commented 7 years ago
laughedelic commented 7 years ago

@eparejatobes do you have anything against it?

eparejatobes commented 7 years ago

Nothing against scalafmt per se, a lot against the "official" style guide(s).

laughedelic commented 7 years ago

I read it as you're fine with using it with certain adjustments to the formatter configuration.

If certain means wiping out defaults completely, yes.

laughedelic commented 7 years ago

I guess, you meant to reply instead of editing my message.

wiping out defaults completely

I don't get it. You want to write your own formatting config from scratch and maintain it?

eparejatobes commented 7 years ago

I don't get it. You want to write your own formatting config from scratch and maintain it?

If I'm using scalafmt, yes.

eparejatobes commented 7 years ago

Yes, I wanted to reply, sorry :laughing:

laughedelic commented 7 years ago

If I'm using scalafmt, yes.

Why? Is the default one so bad and unappealing to you? (did you check it?) Why wasting time doing it from scratch instead of reusing the default and tweaking a couple of things that you don't like? (I don't like it either)

Anyway, if you are really going to do it, it's fine with me. I just want to have a unified automatic formatting and simplify diffs in PR reviews..