search

ohnosequences / sbt-s3-resolver

:cloud:Amazon S3-based resolver for sbt
GNU Affero General Public License v3.0
117 stars 29 forks source link

Optionally set object ACL #54

Closed hkupty closed 7 years ago

hkupty commented 7 years ago

Hi! Currently, sbt-s3-resolver sets the default ACL value as PublicRead. While that can easily be changed to Private, I'd still need to have a s3:PutObjectAcl permission when running.

What I'd like is to optionally set the ACL value (such as Some(CannedAccessControlList.PublicRead)) and, if None, don't supply an ACL value at all, using the bucket default instead.

I understand that this would also affect ivy-s3-resolver, but if you agree, I can come up with PRs for both projects.

Cheers, Henry Kupty

laughedelic commented 7 years ago

Hey @hkupty! Sounds like a good idea 👍 Pull-requests are always welcome.

hkupty commented 7 years ago

I think this can be closed now. Thank you very much for the plugin and the supportiveness! Cheers

laughedelic commented 7 years ago

It's my pleasure 😊 Thanks for contributing!