search

ohnosequences / sbt-s3-resolver

:cloud:Amazon S3-based resolver for sbt
GNU Affero General Public License v3.0
117 stars 29 forks source link

Make s3acl take an optional value #55

Closed hkupty closed 7 years ago

hkupty commented 7 years ago

So we can resort back to inheriting the bucket default setting instead of explicitly setting a value for it.

This depends on ohnosequences/ivy-s3-resolver#20.

I'll fix the comments there and then update here. Still I wanted to open this so the desing of this change can be debated as well.

Also, ref #54.

hkupty commented 7 years ago

Seems to be complete now. I'm leaving the PR open for you to edit, just so you can bump the ivy-s3-resolver version.

Thanks for helping and accepting the PR. Cheers, Henry Kupty

laughedelic commented 7 years ago

Done! 🎉 Released in v0.18.0.

Thanks for the contribution @hkupty 👍