ohoachuck
commented
7 years ago Thanx Daniel, indeed this is not that actively maintained, but still useful. Thank you again for sharing your improvements.
O.
On 18 Sep 2017, at 19:00:50, Daniel Jalkut <notifications@github.com mailto:notifications@github.com> wrote:
I realize you don't really actively maintain these scripts but I still find them useful. Sorry for the massive number of pull requests. I finally decided to just send one last pull request with my current master in case you want any of the recent tweaks I've made.
You can view, comment on, or merge this pull request online at:
https://github.com/ohoachuck/wwdc-downloader/pull/76 https://github.com/ohoachuck/wwdc-downloader/pull/76 Commit Summary
Sanitize the name of the script to just "wwdcDownloader.sh" and remove the old-and-busted version of the script that relies upon wget. Update README to reflect script renaming. Factor out password fetching and build in support to read from and save to the system keychain. Merge branch 'keychain' Merge commit 'd05b17bf90ee5b0ef2b387f6a4b15baef94fca34' Merge commit '3ce1a3dce976c218958724d21994283e95259748' Some resources are referenced by full URL including the hostname, so we need to take care not to prepend the hostname manually in that instance. Merge branch 'fix-sample-downloads' In order to run these files on a machine with Xcode 9 developer tools or later, the Swift version must be specified to support older Swift 3 sources. Merge branch 'specify-swift-version' Add a command line option for downloading just the sample code. Merge branch 'samples-only' Also add the sample-only option for 2016 downloader. Fix sample code downloads for 2016 too. Ensure that resources whose names do not already have the session number prefix get saved with the session number as part of the file name. For example this helps to categorize sample code downloads. Adapt the wwdc2017.swift script to work with Fall 2017 videos. File Changes
A fall2017.swift https://github.com/ohoachuck/wwdc-downloader/pull/76/files#diff-0 (559) M wwdc2016.swift https://github.com/ohoachuck/wwdc-downloader/pull/76/files#diff-1 (32) M wwdc2017.swift https://github.com/ohoachuck/wwdc-downloader/pull/76/files#diff-2 (28) R wwdcDownloader.sh https://github.com/ohoachuck/wwdc-downloader/pull/76/files#diff-3 (0) Patch Links:
https://github.com/ohoachuck/wwdc-downloader/pull/76.patch https://github.com/ohoachuck/wwdc-downloader/pull/76.patch https://github.com/ohoachuck/wwdc-downloader/pull/76.diff https://github.com/ohoachuck/wwdc-downloader/pull/76.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ohoachuck/wwdc-downloader/pull/76, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfO8ZzJJIMmxfP_D5yaq6GNqEv8-Ruoks5sjqHCgaJpZM4PbOHE.
I realize you don't really actively maintain these scripts but I still find them useful. Sorry for the massive number of pull requests. I finally decided to just send one last pull request with my current master in case you want any of the recent tweaks I've made.