search

ohowe1 / SpectatorModeRewrite

Minecraft plugin that allows players to go into spectator mode but enables admins to prevent features of it.
https://www.spigotmc.org/resources/smp-spectator-mode-1-16-support.77267/
MIT License
17 stars 9 forks source link

add support for supervanish #50

Closed quiquelhappy closed 2 years ago

quiquelhappy commented 2 years ago

this will automatically vanish or unvanish players once they enter spectator mode, regardless on the player permissions. this is useful for server owners wanting staff members to use supervanish without influencing gameplay while on it. this feature is disabled by default and can be enabled by changing "supervanish-hook" in the config.

I tested it and works perfectly.

ohowe1 commented 2 years ago

Thanks for the PR. I currently don’t have access to my computer to test these changes but once I do I will test and merge.

quiquelhappy commented 2 years ago

tbh I dont understand why the check failed. nothing changed, the feature is only enabled when enabling the setting. everything seems to work alright on my end. let me know if I can help with anything.

ohowe1 commented 2 years ago

tbh I dont understand why the check failed. nothing changed, the feature is only enabled when enabling the setting. everything seems to work alright on my end. let me know if I can help with anything.

Check failed cause the coverage reporter is configured wrong. All the tests passed.