ohsewon / test

0 stars 0 forks source link

[WIP] [Load] Add common internal functions #378

Open ohsewon opened 6 years ago

ohsewon commented 6 years ago

Issue by myungjoo-ham Tuesday Jul 31, 2018 at 10:54 GMT Originally opened as https://github.sec.samsung.net/STAR/nnstreamer/pull/378


Add common internal functions for tensor_load filter. It appears that these can be shared with tensor_save later as well.

This prepares #322

Signed-off-by: MyungJoo Ham myungjoo.ham@samsung.com

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [*]Skipped
  2. Run test: [ ]Passed [ ]Failed [X]Skipped

myungjoo-ham included the following code: https://github.sec.samsung.net/STAR/nnstreamer/pull/378/commits

ohsewon commented 6 years ago

Comment by git-bot-sec Tuesday Jul 31, 2018 at 10:54 GMT


:memo: Version: 1.20180719. Thank you for submitting PR #378. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://aaci.mooo.com/.

ohsewon commented 6 years ago

Comment by git-bot-sec Tuesday Jul 31, 2018 at 10:55 GMT


:octocat: cibot: @myungjoo-ham, include/tensor_common.h does not include doxygen tags such as @file @brief @author @bug. You must include the doxygen tags in the source code at least.

ohsewon commented 6 years ago

Comment by git-bot-sec Tuesday Jul 31, 2018 at 10:55 GMT


:octocat: cibot: @myungjoo-ham, You wrote code with incorrect doxygen statements. Please check a doxygen rule at http://github.sec.samsung.net/STAR/TAOS-CI/blob/tizen/ci/doc/doxygen-documentation.md

ohsewon commented 6 years ago

Comment by git-bot-sec Tuesday Jul 31, 2018 at 10:55 GMT


:octocat: cibot: @myungjoo-ham, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.sec.samsung.net/STAR/nnstreamer/wiki/.

ohsewon commented 6 years ago

Comment by myungjoo-ham Tuesday Aug 07, 2018 at 12:03 GMT


HOLD THIS PR. I had totally incorrect understandings on how to design tensor_load.