ohsu-comp-bio / cwl-tes

cwl-tes submits your tasks to a TES server. Task submission is parallelized when possible.
Apache License 2.0
18 stars 28 forks source link

Use hostname instead of netloc when connecting to FTP? #36

Closed jvkersch closed 3 years ago

jvkersch commented 4 years ago

See here: https://github.com/ohsu-comp-bio/cwl-tes/blob/fd1e38b148a04ef2865ec4460c0e656266b93af8/cwl_tes/ftp.py#L58

This came up while using cwl-tes to submit jobs into Funnel. Using the hostname means that one can specify a full FTP URL with username and password (e.g. ftp://user:password@mymachine.com/. The hostname for that translates to mymachine.com, but the network locator is still user:password@mymachine.com, and this may confuse the downstream TES executor.