Closed adamnovak closed 3 years ago
Does #35 fix the issue?
I pulled it in for testing in https://ucsc-ci.com/databiosphere/toil/-/jobs/97312. If not I would expect to see those messages recur there.
OK, it looks like the fix in #35 does in fact work!
setup.py
requires exactlypython-dateutil
2.6.1, whilerequirements.txt
asks for that version or later.https://github.com/ohsu-comp-bio/py-tes/blob/7606dc8c74fb69ac65e1fb3acf8c16aa4cb42d9e/setup.py#L44
https://github.com/ohsu-comp-bio/py-tes/blob/7606dc8c74fb69ac65e1fb3acf8c16aa4cb42d9e/requirements.txt#L3
This is managing to confuse
pip
in my usage (possibly with the old resolver that can't intersect requirements). I end up with some of my dependent package entrypoints bailing out with apkg_resources.ContextualVersionConflict
; my package has its own dependency on justpython-dateutil
at any version.The
setup.py
requirement should be changed to specify a minimum version, like therequirements.txt
does. If a<3
is needed, that could be added, but I don't think there's a good reason to pin this exact version. What if someone wants to usepy-tes
in a package that needs a newpython-dateutil
feature, or that also depends on another module that does this same thing but with a different version ofpython-dateutil
?