Service info access method assumes off-spec route

ohsu-comp-bio / py-tes

Python SDK for the GA4GH Task Execution API

https://py-tes.readthedocs.io/

MIT License

5 stars 10 forks source link

Service info access method assumes off-spec route #39

Open uniqueg opened 1 year ago

uniqueg commented 1 year ago

In py-tes 0.4.2 (and probably earlier) the service info controller assumes a route that is incompatible with the TES v1.0 and v1.1 specifications.

In particular, the controller assumes a route v1/tasks/service-info, while the specs require v1/service-info (or rather ga4gh/tes/v1/service-info, compare #40), without tasks/.

uniqueg commented 1 year ago

Here the possible options I see are pretty much number 2. and 3. from #40:

Expect the endpoint at /service-info (could still work for current Funnel if the py-tes consumer tries passing f"{url}/tasks/ - just for accessing the service info)
Try both locations, starting with /service-info, then, in case of 404, trying /service-info/tasks for legacy support

There isn't really an equivalent to 1. obviously.

What do you think, @kellrott?

uniqueg commented 1 year ago

Following #40, will go for the second option here.

Changing the endpoint is an issue for Funnel v1.1 though.