Open RobCodemonkey opened 4 years ago
I just installed the plugin last night, using netdata v1.24.0-106-nightly. I'm getting the same error RobCodemonkey indicates on "line 90", that speedtest-cli reports no such file or directory. I have checked, and speedtest-cli does exist at that path, and speedtest-cli does work when executed manually.
Well, after playing with the plugin script a little bit, I've determined that it is actually running, even with the "no such file or directory" error. That seems like it's just a first-run type of error, and the next iteration of the script does in fact execute speedtest-cli and return values. But I did have to alter the lines which grab the download and upload speeds, and the line which executes speedtest-cli. The current version of speedtest-cli doesn't have the --simple option, and it seems that the positions of the down and up values have shifted right by 1, to fields 8 & 9 instead of 7 & 8. It also seems to solve the issue I had where nothing was getting recorded and plotted on the graph.
I've never submitted a pull request before, but I'd be happy to try, later this evening.
The plugin does seem to be functioning now with my changes, but the graph isn't drawing like the other graphs on the page. Maybe it's because I have the plugin set to execute once per hour, rather than the default 60 seconds.
I gather that it's been a while but I can't see anything overtly wrong (though I 100% may just be stupid).
charts.d plugin picks up the speedtest chart definition and if speedtest-cli isn't installed, throws an error - all good so far.
pip install speedtest-cli
running speedtest-cli directly from shell works perfectly and speedtest-cli is present in /usr/binHowever, attempting to run with debug gets me:
2020-04-16 10:54:47: charts.d: INFO: main: started from '/usr/libexec/netdata/plugins.d/charts.d.plugin' with options: debug 60 speedtest 2020-04-16 10:54:47: charts.d: INFO: main: Configuration file '/usr/lib/netdata/conf.d/charts.d.conf' loaded. 2020-04-16 10:54:47: charts.d: WARNING: main: Configuration file '/etc/netdata/charts.d.conf' not found. 2020-04-16 10:54:47: charts.d: DEBUG: speedtest: is enabled for auto-detection. 2020-04-16 10:54:47: charts.d: DEBUG: main: enabled charts: speedtest 2020-04-16 10:54:47: charts.d: DEBUG: speedtest: loading module: '/usr/libexec/netdata/plugins.d/../charts.d/speedtest.chart.sh' 2020-04-16 10:54:47: charts.d: DEBUG: speedtest: not found module configuration: '/usr/lib/netdata/conf.d/charts.d/speedtest.conf' 2020-04-16 10:54:47: charts.d: DEBUG: speedtest: loading module configuration: '/etc/netdata/charts.d/speedtest.conf' **/usr/libexec/netdata/plugins.d/charts.d.plugin: line 90: SPEEDTEST-CLI_CMD=/usr/bin/speedtest-cli: No such file or directory**
I'm happy to attempt to fix and submit a PR but could use a clue :)