ohwgiles / laminar

Fast and lightweight Continuous Integration
https://laminar.ohwg.net
GNU General Public License v3.0
300 stars 54 forks source link

Support Clang/LLVM build on FBSD #198

Closed marian-cingel closed 12 months ago

marian-cingel commented 1 year ago
ohwgiles commented 1 year ago

Hi, thanks for this! In case you weren't aware, there was an earlier attempt to port to FreeBSD that stalled: #170

marian-cingel commented 1 year ago

Hi, thanks for this! In case you weren't aware, there was an earlier attempt to port to FreeBSD that stalled: #170

Hello, no problem, thanks for creating the Laminar in a first place. Yes, I saw the #170. Fortunately I don't have any issues with autoptr, using Clang/LLVM_17 on FreeBSD14. Maybe in week or two I will add a FBSD support for PathWatcher, so please wait with this MR. FYI: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273827

ohwgiles commented 1 year ago

Looks good so far. Waiting in case PathWatcher comes along.

marian-cingel commented 1 year ago

Looks good so far. Waiting in case PathWatcher comes along.

Done. It requires to just add libinotify library in CMakeLists.txt - a bridge between inotify API and FBSD kqueue. Do you want to keep "#ifndef WATCH_PATHS_UNSUPPORTED" in server.cpp ? In case someone wants to run it on more exotic systems or should I remove it completely ?

ohwgiles commented 1 year ago

I'd prefer you remove it, it will be easy to reintroduce if we ever need it

marian-cingel commented 1 year ago

I'd prefer you remove it, it will be easy to reintroduce if we ever need it

done. All changes are squashed as single commit.