ohwmakers / OHM-curriculum

Open Hardware Makers Curriculum
https://curriculum.openhardware.space/
MIT License
8 stars 6 forks source link

Review of module 6: licenses & standards #34

Closed thessaly closed 2 years ago

vektorious commented 2 years ago

MAIN

Do you agree with the content?

Yes

Do you agree with the opinions/statements

Yes

Any content to add/remove?

I removed the comment. I guess we don't need it anymore. The text was also doubled. I removed what (I think) was the previous version.

Any assignments to add/remove

No

Any resources to add/remove?

No

vektorious commented 2 years ago

6.1 How licenses work

Do you agree with the content?

Yes - it's a lot of (nice) text and backstory. It might be long to read but it's interesting and it was fun to read (even although I knew the 3D-printer story) I feel like we have the 3D-printer story as an example somewhere else as well but couldn't find it when I was looking for it. EDIT: Found it. It's in module 1.2 brief history of OH. But it just introduces RepRap so that's fine.

Do you agree with the opinions/statements

Yes

Any content to add/remove?

I removed the comment. I guess we don't need it anymore.

Any assignments to add/remove

No

Any resources to add/remove?

No

vektorious commented 2 years ago

6.2 Open Hardware Licenses

Do you agree with the content?

Yes

Do you agree with the opinions/statements

Yes

Any content to add/remove?

No

Any assignments to add/remove

No

Any resources to add/remove?

No

vektorious commented 2 years ago

6.3 Documentation Standards

Do you agree with the content?

Yes

Do you agree with the opinions/statements

Yes

Any content to add/remove?

Any assignments to add/remove

No

Any resources to add/remove?

No

vektorious commented 2 years ago

6.4 Findability

Do you agree with the content?

Yes

Do you agree with the opinions/statements

Yes

Any content to add/remove?

You benefit from a transitional sentence between the last paragraph and the assignments. But for now it's fine.

Any assignments to add/remove

No

Any resources to add/remove?

No

amchagas commented 2 years ago

Just reviewed the comments and added changes as a commit