Shortcodes Not Properly Configured for All Supported Attributes

[eberhapa]

Hi,

You are passing $atts to get_authentification_url() in make_login_button() but everything beside button_text is removed from $atts. So If I do the shortcode like that: [openid_connect_generic_login_button button_text="Über Learnlinked anmelden" redirect_to="test"] and check $atts in make_login_button() everything is fine. When I check $atts in get_authentification_url() only button_text is there. Could you add all attributes in make_login_button() to make it work? All the best, Patrick

[eberhapa]

I tried you other shortcode do_shortcode('[openid_connect_generic_auth_url redirect_to="' . home_url() . '/jobboerse"]') and found that the redirect isn't working at all. I'm always redirected to the page where the login button/link is.

[timnolte]

I'm not sure if WordPress Core changed the shortcode_atts function at some point, though I suspect when the shortcodes were added there was an incorrect understanding of how the function worked. Basically, the call to shortcode_atts is not supplying all the supported attributes, with default values, in the first argument. This needs to be fixed.

See: https://developer.wordpress.org/reference/functions/shortcode_atts/

[timnolte]

Relevant lines to be fixed:

• https://github.com/oidc-wp/openid-connect-generic/blob/develop/includes/openid-connect-generic-login-form.php#L139
• https://github.com/oidc-wp/openid-connect-generic/blob/develop/includes/openid-connect-generic-client-wrapper.php#L211

[eberhapa]

No problem. Thank you :)

And whats with the do_shortcode('[openid_connect_generic_auth_url redirect_to="' . home_url() . '/jobboerse"]') issue? The attribute is correct there but the redirect isn't working.

[eberhapa]

Any news on that?