oie-mines-paristech / lca_algebraic

Layer over brightway2 for algebraic definition of parametric models and super fast computation of LCA
BSD 2-Clause "Simplified" License
37 stars 18 forks source link

Cannot install on M series Mac #50

Open Michael-ljn opened 5 months ago

Michael-ljn commented 5 months ago

Hey,

Just tried to install the v.1.1 but pypardiso is listed in the requirements and is not supported on M1 Macs. I assume linear algebra calculation method is covered by the version of brightway install and this new version should work without pypardiso as a requirement.

raphaeljolivet commented 5 months ago

Hi,

Indeed, Brightway does not come anymore with an accelerator librairy installed out of the box, and people need to install it manually : [ https://docs.brightway.dev/en/latest/content/installation/index.html | https://docs.brightway.dev/en/latest/content/installation/index.html ]

I find it quite bothering : People don't notice they don't have a proper solver and things are just running super slow. That's why I added pypardisio in the requirements, so most users have an acceleration out of the box.

But indeed it breaks on M1.

I can add a condition to only require it on x86 architecture.

Can you please provide the output for the following commands ?

import platform platform.platform() ??

platform.system() ??

platform.architecture() ??

platform.processor() ??

De: "Michael Lejeune" @.> À: "oie-mines-paristech/lca_algebraic" @.> Cc: "Subscribed" @.***> Envoyé: Lundi 29 Avril 2024 10:35:54 Objet: [oie-mines-paristech/lca_algebraic] Cannot install on M series Mac (Issue #50)

Hey,

Just tried to install the v.1.1 but pypardiso is listed in the requirements and is not supported on M1 Macs. I assume linear algebra is covered calculation method is covered by the version of brightway install and this new version should work without pypardiso as a requirement.

— Reply to this email directly, [ https://github.com/oie-mines-paristech/lca_algebraic/issues/50 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AAJFLQDJHXIPC42JQCN2UL3Y7YA6VAVCNFSM6AAAAABG54CTLCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DQNBTHE4TCMI | unsubscribe ] . You are receiving this because you are subscribed to this thread. Message ID: <oie-mines-paristech/lca_algebraic/issues/50 @ github . com>

Michael-ljn commented 5 months ago

I see, indeed I have some troubles installingscikit-umfpack accelerator for the ARM architecture, and sometimes I get warnings for trying to solve a singular matrix such as this one UmfpackWarning: (almost) singular matrix! (estimated cond. number: 1.55e+12)

Solving the initial (big) LCA calculation can take up to 14mins in my case.... Then for the other calculations it's fortunately it's very fast with lca_algebraic, but still very annoying indeed. Here is the result of what you asked:

'macOS-14.4.1-arm64-arm-64bit' 'Darwin' ('64bit', '') 'arm'

Thanks for the software, it's a very good one!

raphaeljolivet commented 5 months ago

Hi,

Could you please try to install this version ? [ https://pypi.org/project/lca-algebraic-dev/1.1.1753145.dev0/ | https://pypi.org/project/lca-algebraic-dev/1.1.1753145.dev0/ ]

I have removed the dependency to pypardiso when building for "arm"

De: "Michael Lejeune" @.> À: "oie-mines-paristech" @.> Cc: "Raphael JOLIVET" @.>, "Comment" @.> Envoyé: Mardi 30 Avril 2024 06:30:07 Objet: Re: [oie-mines-paristech/lca_algebraic] Cannot install on M series Mac (Issue #50)

I see, indeed I have some troubles installing scikit-umfpack accelerator for the ARM architecture, and sometimes I get warnings for trying to solve a singular matrix.... Also solving the initial (big) LCA calculation can take up to 14mins in my case.... Then for the other calculations it's fortunately it's very fast with lca_algebraic , but still very annoying indeed. Here is the result of what you asked:

'macOS-14.4.1-arm64-arm-64bit' 'Darwin' ('64bit', '') 'arm'

Thanks for the software, it's a very good one!

— Reply to this email directly, [ https://github.com/oie-mines-paristech/lca_algebraic/issues/50#issuecomment-2084356763 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AAJFLQD4A5EW75E76GSAB53Y74M47AVCNFSM6AAAAABG54CTLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUGM2TMNZWGM | unsubscribe ] . You are receiving this because you commented. Message ID: <oie-mines-paristech/lca_algebraic/issues/50/2084356763 @ github . com>