oierbravo / createsifter

Create Sifter mod for Forge
MIT License
5 stars 17 forks source link

Brass sifter configuration bug #46

Open JondorTheBrinkinator opened 11 months ago

JondorTheBrinkinator commented 11 months ago

Describe the Bug

In both the Minecraft 1.19 and 1.20 version of this mod, the brass sifter configuration uses "outputCapacity" for both the output inventory capacity and items per cycle configuration values, meaning that they cannot be configured separately.

Reproduction Steps

  1. Visit https://github.com/oierbravo/createsifter/blob/mc1.19/dev/src/main/java/com/oierbravo/createsifter/content/contraptions/components/brasss_sifter/BrassSifterConfig.java (The main MC 1.19 branch is linked, but the bug exists in both 1.19 and 1.20)
  2. View lines 21 and 24
  3. Observe the duplicated string "outputCapacity" in both configuration variables

Expected Result

I expected both parameters to be configurable separately.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

1.20.1-1.8.1.e-22

Minecraft Version

1.20.1

Forge Version

47.2.0

Other Mods

No response

Additional Context

No response

github-actions[bot] commented 11 months ago

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.