oiltanker / multiplayer-crew-manager

https://steamcommunity.com/sharedfiles/filedetails/?id=2775613786
MIT License
5 stars 6 forks source link

No longer works in 0.19.11.0 #1

Closed AnalogKnight closed 1 year ago

AnalogKnight commented 1 year ago

Thank you for creating such a great mod, but this mod no longer works after the 0.19.11.0 update, please fix.

oiltanker commented 1 year ago

I'm welcoming all pull requests :)

Akronyhm commented 1 year ago

I´ve begun work on a fix - But I´m new to the whole GIT interface so... yeah

Anyway I´ve gotten the mod restored to seemingly working order - I just need to test it in a proper lobby and then figure out how the whole "pull request" thing works

oiltanker commented 1 year ago

Eagerly awaiting pull request :).

Akronyhm commented 1 year ago

The largest point(s) of worry are/were in McmSave.cs (Lines 110, 111) because these properties can no longer be assigned in this manner - PipeConnection can no longer use a simple integer in its CTOR, and SteamID has had its "Set" accessor removed

I'm not sure what these properties ever did in the dummy client (or if they´re even of consequence), but so far I´ve managed to start a multiplayer lobby in my lonesome and successfully switched my active character to a bot - I just need to make sure that multiple players can freely switch around, complete a few missions, etc... kill someone and make sure that they can respawn as intended, and that skills/perks work as intended.

I´ve pushed the changes to my own fork of the project in the meantime, and I´ll submit my pull request once everything has a green light

AnalogKnight commented 1 year ago

I´ve begun work on a fix - But I´m new to the whole GIT interface so... yeah

Anyway I´ve gotten the mod restored to seemingly working order - I just need to test it in a proper lobby and then figure out how the whole "pull request" thing works

Outstanding Work! I try to fix it but my knowledge is not enough. Your work will save a lot of people's multiplayer games.

Akronyhm commented 1 year ago

status update - the mod was in worse shape than I originally surmised

Hoist the sails and the subsequent updates to Lua/CS for Barotrauma caused cascading issues all throughout the mod... :<

The beast is reeling - but I'm forging ahead at a rapid pace (learning the whole modding API things as I go)

Currently, I've managed to restore/add mod functionality in the following areas:

Still need to test the following areas:

Akronyhm commented 1 year ago

Created a pull request - Mod functionality has seemingly been fully restored and tested