oinkin / treestyletab

Tree Style Tab bare minimum working version for Pale Moon
27 stars 5 forks source link

Double-writing on tabs in some personas; not taking into account shadow color #7

Closed graciecat closed 5 years ago

graciecat commented 6 years ago

I love Tree-Style Tabs. I also like switching up personas ("lightweight themes"). I've noticed that TST does not play nicely with some of the personas. For example, here are Blue Moon, Night Owl by MaDonna (with tabs on the right) and Colorful Fractal:

https://s6.postimg.org/o2hvf18dt/TST_Blue_Moon.png https://s6.postimg.org/e959fyvn5/TST_Night_Owl_tabs_on_right.png https://s6.postimg.org/5bkjim375/TST_Colorful_Fractals.png

You can see that on the tabs we get double-writing, although the URL bar is fine.

The issue does not appear in other personas. For example, Balao and Japanese Tattoo (with tabs on the right) are just fine:

https://s6.postimg.org/l0voitkmp/TST_Balao.png https://s6.postimg.org/62d9oe5kh/TST_Japanese_Tattoo_tabs_on_right.png

The issue appears when the persona designer indicates a shadow color. If TST doesn't take this into account and doesn't override the persona's styling, it is possible to end up with the persona's styling on top of TST's fixed background. And you get double-writing and maybe other artifacts. (See also this thread in the Pale Moon forum.)