search

oirlab / liger_iris_pipeline

Data Reduction System (DRS) for the Thirty Meter Telescope IRIS imager/spectrograph
https://oirlab.github.io/iris-pipeline
0 stars 3 forks source link

Subarrays support implementation #14

Closed zonca closed 4 years ago

zonca commented 4 years ago

Implement #11

zonca commented 4 years ago

@arunsurya77 I've completed the support for subarrays, would you like to review the pull request and provide feedback?

arunsurya77 commented 4 years ago

Great I will check it out this week.

On Tue, 28 Jan 2020 at 19:18, Andrea Zonca notifications@github.com wrote:

@arunsurya77 https://github.com/arunsurya77 I've completed the support for subarrays, would you like to review the pull request and provide feedback?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oirlab/iris_pipeline/pull/14?email_source=notifications&email_token=AKB37LVILE4V64VHEVSQZSLRADYSFA5CNFSM4KJJFMD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFZR4A#issuecomment-579574000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKB37LUWLB54ZLFZRHFFS3DRADYSFANCNFSM4KJJFMDQ .

zonca commented 4 years ago

@arunsurya77 can you please provide feedback on this pull request?

arunsurya77 commented 4 years ago

yes , Sorry about the delay. Will try to finish it tomorrow.

On Wed, 12 Feb 2020 at 17:59, Andrea Zonca notifications@github.com wrote:

@arunsurya77 https://github.com/arunsurya77 can you please provide feedback on this pull request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oirlab/iris_pipeline/pull/14?email_source=notifications&email_token=AKB37LQSUGB5MFLCNZT77BLRCSSP7A5CNFSM4KJJFMD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELTDCZQ#issuecomment-585511270, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKB37LUOD37XBTJAHU6AMHLRCSSP7ANCNFSM4KJJFMDQ .

arunsurya77 commented 4 years ago

Hi Andrea,

I posted this is in slack so probably you didn't see. Is there test data to test subarrays. Also, I get this weird error when I try to run the tests script. pytest: error: unrecognized arguments: --current-env --nbval-lax inifile: /home/arun/asurya_dev/iris_pipeline_subarr/iris_pipeline/setup.cfg rootdir: /home/arun/asurya_dev/iris_pipeline_subarr/iris_pipeline11:24 What is the testing package used ?

Cheers Arun

zonca commented 4 years ago

nbval https://github.com/computationalmodelling/nbval

zonca commented 4 years ago

added to the docs: e915162aa5ecb2f423c26832a9d5a38833547b69

zonca commented 4 years ago

@arunsurya77 I'll merge this, still if you send feedback I'll incorporate it later.

arunsurya77 commented 4 years ago

Yes that works fine. I reviewed the code that day. But forgot to merge.

On Fri, Mar 6, 2020 at 9:20 PM Andrea Zonca notifications@github.com wrote:

@arunsurya77 https://github.com/arunsurya77 I'll merge this, still if you send feedback I'll incorporate it later.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oirlab/iris_pipeline/pull/14?email_source=notifications&email_token=AKB37LTI64DOJHWFEEQGQK3RGHKSLA5CNFSM4KJJFMD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEODPXEI#issuecomment-596048785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKB37LR75V7JAWYUMGNPXKTRGHKSLANCNFSM4KJJFMDQ .