Add DHCP discovery config for Viessmann integration

oischinger / ha_vicare

Inofficial Home Assistant custom component for Viessmann ViCare API

61 stars 34 forks source link

Add DHCP discovery config for Viessmann integration #44

Closed woehrl01 closed 3 years ago

woehrl01 commented 3 years ago

This PR adds the DHCP discovery configuration for Viessmann Devices to the manifest. This can be used in combination with PR #43 to jump into the correct config flow for adding new devices.

woehrl01 commented 3 years ago

The tests are correctly failing currently with "DHCP information in a manifest requires a config flow to exist" as #43 is not yet merged to master.

oischinger commented 3 years ago

Good idea, haven't even thought of MAC address discovery. The manifest entry itself doesn't seem to do anything it seems. I believe I have to implement an additional dhcp discover config flow for this to work. I'll play around with that.

woehrl01 commented 3 years ago

To my understanding, the manifest entry triggers the DHCP discovery flow when implemented.

oischinger commented 3 years ago

I moved your commit over to #43. If you don't mind I'll close this PR?