search

oischinger / ha_vicare

Inofficial Home Assistant custom component for Viessmann ViCare API
61 stars 34 forks source link

Fix the heating action #60

Closed crazyfx1 closed 3 years ago

crazyfx1 commented 3 years ago

The heating type is not used anymore. Also the implementation for heatpump and burners were wrong.

oischinger commented 3 years ago

I wonder if we should not just get rid of current_action if we don't have a better way to implement it. What do you think?

crazyfx1 commented 3 years ago

The new implementation is fine for most users, but wrong for people with multiple compressors / burners. I don't think we can get rid of it, otherwise we don't have the current heating state anymore in HA. image

crazyfx1 commented 3 years ago

Maybe for hybrid devices we will need to combine both compressor active and burner active with an OR.

crazyfx1 commented 3 years ago

I have improved the implementation now and it should work for all users. I think it's safe to assume that the heater is heating as soon as a single compressor / burner is active.