search

oist / LaTeX-templates

Graduate School LaTeX templates for Lab rotation proposal + report, OIST beamer and Thesis + thesis proposal
MIT License
62 stars 56 forks source link

Final option #3

Closed tadashiK closed 5 years ago

tadashiK commented 5 years ago

I added a class file for OIST PhD Thesis such that one can switch from a temporary version to a final version by just changing \documentclass{oist_thesis} to \documentclass[final]{oist_thesis}.

This should introduce two benefits. First, it reduces errors when a student is copying contents from Temporary_Thesis.tex to Final_Thesis.tex. Second, it makes easier to see style differences between temporary and final versions, and thus, makes maintenance comprehensive.

Please check if changes are OK. I am not much familiar with writing class files. Therefore, it is likely that I am making mistakes.

jiegillet commented 5 years ago

This is a great idea, thank you. I'll have a closer look.

tadashiK commented 5 years ago
  • I'd like to be able to use both \documentclass[temporary]{oist_thesis} and \documentclass[final]{oist_thesis} with final as the default option.
  • having mydefinitions.tex only made sense when there were two main .tex files. Now all of its contents it should be included in Thesis.tex, if it doesn't get too messy.

OK. I will work on them.

  • I would love to have a new function \maketitle{\thesistitle, \name, \supervisor, \cosupervisor} (with optional last argument) which replaces all the messy lines

I have been thinking the same thing, but was not sure if others like it. I will work on this too.

tadashiK commented 5 years ago

I did. Please check if changes are OK.

On thing I could not do was redefining \maketitle command. For some reason, redefining \maketitle with \renewcommand causes many errors, but defining an identical command with a different name like \puttitle works. I could not figure out why.

jiegillet commented 5 years ago

This is awesome! There are many details that I want to edit (mostly comments and stuff like that) but it would take too long to make you do it, so I will send a PR to your branch if it's OK!

I'm not surprised that \maketitle complained bout being changed, it's a loaded function. Your renaming is fine!

tadashiK commented 5 years ago

I merged your branch to mine.