search

oitofelix / eterm-fn

Function keys (F1--F12) for GNU Emacs terminal
GNU General Public License v3.0
4 stars 1 forks source link

Rewrite as patch for core Emacs #1

Open skangas opened 4 years ago

skangas commented 4 years ago

This would be useful to have in core, as a fix to Bug#29920: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29920

This is a request to rewrite the code in this package as a patch for core Emacs, possibly as optional and non-default behaviour.

Thanks!

oitofelix commented 4 years ago

Hello Stefan,

Stefan Kangas notifications@github.com writes:

This is a request to rewrite the code in this package as a patch for core Emacs, possibly as optional and non-default behaviour.

What are the changes required to make it acceptable for inclusion in core Emacs?

-- Bruno Félix Rezende Ribeiro (oitofelix) [0x28D618AF] http://oitofelix.freeshell.org/

skangas commented 4 years ago

What are the changes required to make it acceptable for inclusion in core Emacs?

(Sorry for the late reply.)

Basically you'd have to make it into a patch that could be applied to Emacs.

It should be as easy as:

  1. check out the git repository
  2. edit term-mode to add support for this
  3. test it and verify everything works
  4. commit your changes (see CONTRIBUTE for details)
  5. git format-patch -1
  6. send the patch-file to 29920 at debbugs.gnu.org

I think you might want to add an entry in etc/NEWS and a defcustom for this option.

Knusper commented 3 months ago

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29920

it states that this bug is fixed in emacs 29.