search

oitozero / ngSweetAlert

AngularJS wrapper for SweetAlert
MIT License
616 stars 160 forks source link

Fix the version of sweetalert #78

Closed harshavardhan-reddy closed 7 years ago

harshavardhan-reddy commented 7 years ago

Can you fix the version of sweetalert to 1.1.3. The newest version of sweetalert is breaking the ng-sweet-alert

CaporalDead commented 7 years ago

:+1: I'm getting the same issue, I had to fix sweetalert to 1.1.3.

emrealparslan93 commented 7 years ago

Same here.

emrealparslan93 commented 7 years ago

What is the solution? I tried to change "latest" to "angular-sweetalert": "~1.1.3" in bower.json but it didn't help. @harshavardhan-reddy @CaporalDead

Edit : I understand the issue now. I copied this library and linked it with project. Changed "sweetalert" : "1.1.3". Hope this will work.

harshavardhan-reddy commented 7 years ago

@emrealparslan93 Yes you need to install sweetalert manually (1.1.3). This will override the sweetalert installed by ngSweetAlert.

carlosafonso commented 7 years ago

You can also modify your bower.json to point to our forked repository:

{
    "angular-sweetalert": "https://github.com/theviralab/ngSweetAlert.git#c0b746e"
}

This installs the correct version of SweetAlert. This is a temporary solution until PR #79 gets merged.

ricky300300 commented 7 years ago

Fix this issue please, yesterday I wasted my 2-3 hr and found then this issue

carlosafonso commented 7 years ago

Thank you @oitozero for merging #79 .

It seems that declaring the dependency as follows:

{
    "angular-sweetalert": "latest"
}

Still does not work, since if I'm not mistaken latest points to the most recent tagged release (which in this case still contains the old version of bower.json).

Pointing to master instead of latest fixes this. Also, creating a new release should solve this as well.

Srounsroun commented 7 years ago

83 can fix the issue