Remove OnlyIn and rework registration

oitsjustjose / Geolosys

A logical, geological system in Minecraft

GNU General Public License v3.0

43 stars 37 forks source link

Remove OnlyIn and rework registration #306

Closed lukebemish closed 2 years ago

lukebemish commented 2 years ago

Fix general good practice by:

Removing @OnlyIn annotation where necessary and refactoring code for client/server seperation.
Changing registry system to use DeferredRegister to avoid log spam and occasional crashing.

This should, among other things, future-proof the code a bit, as well as stopping the constant log spam during loading caused by the old system and should also, at least as far as I can tell, fix the occasional crashes I was experiencing with the old system.

oitsjustjose commented 2 years ago

Testing locally and all seems to be working well. Have you tested on the server by chance?

lukebemish commented 2 years ago

I ran a server, but didn't join it with a player. I'll give that a try.

lukebemish commented 2 years ago

Yep, just started one up and joined, couldn't seem to do anything that made it crash.