oitsjustjose / V-Tweaks

Adding Little Tweaks to Vanilla Minecraft without Adding New Items
https://oitsjustjose.com/Mods/V-Tweaks
GNU General Public License v3.0
9 stars 8 forks source link

This mod somehow breaks the particle engine after a while #109

Open SmolFloofyRedhead opened 10 months ago

SmolFloofyRedhead commented 10 months ago

I first saw this bug in the Life in the Village 3 pack, which went from 1.18 to 1.19 and had this bug in both versions with identical behavior. It took a lot of testing involving multiple instances with various mods removed, basically a brute-force test. Nothing is logged when it happens, not even in the debug log. It happens even when this is the only mod installed.

What happens is this: First, all particles stop spawning for a few seconds. Existing particles remain, animate, and fade out as normal. On the debug screen, the particle count drops to 0 as they fade away. Then, all the particles that should have spawned in those few seconds appear in a burst. Block breaking particles will, notably, appear in a line a few blocks off the ground or a long cluster on the ground if they spawn within view. Other particles will appear at their normal sources. The particle count will update as expected. Sometimes there will be more than one burst, with particles spawning off and on before the engine completely breaks. Then, no more particles spawn until the game is restarted, with the count in the debug screen staying at 0. Sometimes, however, the particles will work for a short time, then stop spawning entirely again. Usually this happens after dying or changing dimensions. It is client sided. I've been hosting a LAN world over Hamachi, and my friend does not play long enough to trigger the bug. His particles will work fine while mine don't.

The bug is difficult to trigger in normal gameplay, and triggers very inconsistently.

In 1.19 however, Structurize previews seem to trigger it very quickly. In my own tests and normal gameplay, previewing a few buildings would cause it to trigger shortly after, but not immediately. They do NOT trigger it in 1.18.

It can also be triggered fairly quickly by using 4 command blocks all running the following command in repeat mode:

particle minecraft:flame ~ ~1 ~ .125 .125 .125 0 1000 force

This should look like a fireball above the block.

It is present in all 1.19 versions and most or all 1.18 versions. It may be present in 1.16 as well but I haven't tested it yet.

oitsjustjose commented 10 months ago

Could use some logs for this one as it's so difficult to repro - let me know if you can provide any!

SmolFloofyRedhead commented 9 months ago

Well... nothing gets logged when it happens, but fine. I rigged up a completely fresh install with only Forge and V-Tweaks. Set up the test. 4 flaming command blocks. It triggered in only a few minutes and I managed to record it with Shadowplay. This time, the particle engine died a lot more slowly than in other tests. Here's the logs, with my real name removed from them. It was in the filepaths. Sorry about the spam in the logs from the command blocks, but I felt I should leave everything intact. debug real name removed.log latest real name removed.log

Also, someone mentioned that disabling the client config setting for custom challenger mob particles might have worked. I'll test that and update with results.

Update: With the custom challenger particles enabled (the first test), it happened in about 4 or 5 minutes. With it disabled, it ran for over 10 minutes, the log exceeded 100,000 lines, and it still didn't happen.

Whatever custom thing you did to give the challenger mobs their particles is breaking things.

oitsjustjose commented 9 months ago

Good to know - I've got an alternative particle spawning system worked out, giving it a try with your super helpful repro steps now :)

SmolFloofyRedhead commented 9 months ago

Why not just use the vanilla method of spawning particles on an entity? I've never seen a mod that adds mobs with particle effects do this. Hell, I've never seen any mod do this at all.

Sergo467 commented 8 months ago

I'm facing the same problem.

CraftyZombie commented 5 months ago

I think a temporary fix is to disable Challenger Mob particles, this issue has been driving me crazy for months and I finally found it to be V-Tweaks.