search

oizma / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Too aggressive removal of semicolons in GLSL backend #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
http://codereview.appspot.com/1301041 introduced a bug where the removal of 
extraneous semicolons is too aggressive. This is causing failures in the OpenGL 
ES 2.0 conformance tests.

The shader fragment which seems to be translated incorrectly is

 (j>k)?( result1 = true ):( result1 = false );
 (y<n)?( result2 = true ):( result2 = false );

And from recollection this is being translated to

 (j>k)?( result1 = true ):( result1 = false )(y<n)?( result2 = true ):( result2 = false );

The name of the failing test is "selection_frag_test".

Original issue reported on code.google.com by kbr@chromium.org on 7 Jun 2010 at 11:13

GoogleCodeExporter commented 9 years ago

Original comment by kbr@chromium.org on 7 Jun 2010 at 11:16

GoogleCodeExporter commented 9 years ago

Original comment by kbr@chromium.org on 7 Jun 2010 at 11:17

GoogleCodeExporter commented 9 years ago

Original comment by kbr@chromium.org on 7 Jun 2010 at 11:23

GoogleCodeExporter commented 9 years ago

Original comment by alokp@chromium.org on 11 Jun 2010 at 6:56

GoogleCodeExporter commented 9 years ago 
Fixed in rev335
http://code.google.com/p/angleproject/source/detail?r=335

Original comment by alokp@chromium.org on 14 Jun 2010 at 5:35