oizma / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Shader translator needs option to enforce GLSL ES limitations #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The WebGL 1.0 specification states that the minimum requirements for control 
flow and indexing (sections 4 and 5 of Appendix A of the GLSL ES specification) 
are enforced. For example, the upper bound of the loop must be a constant 
expression (it can not involve the value of a uniform variable), and indexing 
of uniform arrays in fragment shaders must only allow 
constant-index-expressions (i.e., no expressions involving uniform or varying 
values).

An option is needed in the ANGLE shader translator to strictly enforce these 
minimum requirements. This could be folded into the existing WebGL language 
support, or exposed as another capability.

Original issue reported on code.google.com by kbr@chromium.org on 30 Sep 2010 at 5:59

GoogleCodeExporter commented 9 years ago
I wrote some code this summer to implement this (attached). My internship at 
Apple is over, but I'd still be happy to work with you on integrating this into 
the ANGLE codebase. It implements the limitations in section 4 for the GLSL ES 
specification.

Original comment by automin@gmail.com on 3 Oct 2010 at 12:37

Attachments:

GoogleCodeExporter commented 9 years ago
Hi Paul,
Thanks for attaching your patch. I will keep you posted.

-Alok

Original comment by alokp@chromium.org on 4 Oct 2010 at 9:26

GoogleCodeExporter commented 9 years ago

Original comment by alokp@chromium.org on 9 Nov 2010 at 10:22

GoogleCodeExporter commented 9 years ago
http://codereview.appspot.com/3225041 out for review. This CL validates the 
form of control-flow and indexing.

Original comment by alokp@chromium.org on 19 Nov 2010 at 8:07

GoogleCodeExporter commented 9 years ago
Alok landed his changes some time ago. Closing as fixed.

Original comment by kbr@chromium.org on 7 Oct 2011 at 2:34