Infinite loop in shader causes crash (assertion) in TOutputGLSL::visitLoop

[GoogleCodeExporter]

Originally reported there:
https://bugzilla.mozilla.org/show_bug.cgi?id=601086

What steps will reproduce the problem?
1. Make sure ANGLE assertions are enabled (debug build).
2. Load attached testcase in a WebGL-enabled browser that uses ANGLE for shader 
translation/validation.

What is the expected output? What do you see instead?

Expected: no crash (and the shader should be rejected as non-GLSL-ES compliant).
Actual: crash in ANGLE in TranslatorGLSL::compile() in TOutputGLSL::visitLoop.

What version of the product are you using? On what operating system?
Using ANGLE r385, Mozilla's copy (under gfx/angle/), on Windows 7.

Original issue reported on code.google.com by jacob.be...@gmail.com on 1 Oct 2010 at 7:35

Attachments:

• testcase.html
• callstack.txt

[GoogleCodeExporter]

Original comment by alokp@chromium.org on 7 Oct 2010 at 5:05

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by alokp@chromium.org on 7 Oct 2010 at 5:08

[GoogleCodeExporter]

I will fix the crash. But why do you state that "the shader should be rejected 
as non-GLSL-ES compliant"? What exactly is non-compliant? A for-loop without a 
condition is allowed according to GLSL ES 1.0 spec.

Original comment by alokp@chromium.org on 13 Oct 2010 at 8:09

• Changed state: Started

[GoogleCodeExporter]

That depends on whether we follow the Appendix A restrictions or not for loops

Original comment by vladim...@gmail.com on 13 Oct 2010 at 11:15

[GoogleCodeExporter]

There is another bug filed for enforcing Appendix A restrictions:
http://code.google.com/p/angleproject/issues/detail?id=48

Original comment by alokp@chromium.org on 13 Oct 2010 at 11:31

[GoogleCodeExporter]

Fixed in r451.

Original comment by alokp@chromium.org on 14 Oct 2010 at 4:18

• Changed state: Fixed