Closed GoogleCodeExporter closed 9 years ago
Original comment by kbr@chromium.org
on 6 Oct 2010 at 10:24
I will be happy to submit the patch, but could you please submit a patch
created from the root directory of ANGLE. It seems to be created from
gfx/angle, and Tortoise svn is having a hard time merging it correctly.
Original comment by alokp@chromium.org
on 13 Oct 2010 at 8:31
It can be trivially applied with
patch -p3 < .../angle-nspr.patch
Original comment by kbr@chromium.org
on 13 Oct 2010 at 9:00
I usually work on windows which does not have the "patch" command. If it is
easy for you to submit another patch, please do. Alternatively I can also do it
on linux or install cygwin.
Original comment by alokp@chromium.org
on 13 Oct 2010 at 9:11
Vlad's a busy guy and I don't think it's reasonable to reject this patch when
it would take literally five minutes to clean it up on Linux or Mac. Attached
is the rebased patch.
Original comment by kbr@chromium.org
on 13 Oct 2010 at 10:15
Attachments:
Original comment by alokp@chromium.org
on 13 Oct 2010 at 10:47
Sorry, just read through this -- thanks :) For future reference -- a
search/replace of the pathnames in the patch with any editor would have worked
as well :)
Original comment by vladim...@gmail.com
on 14 Oct 2010 at 1:55
Fixed in r454.
Original comment by alokp@chromium.org
on 14 Oct 2010 at 6:21
Original issue reported on code.google.com by
vladim...@gmail.com
on 6 Oct 2010 at 9:15Attachments: