oizma / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

MacroExpand leaks in, in->args, in->args[] for various failure cases #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. run Coverity on mozilla-central from something after 
http://hg.mozilla.org/mozilla-central/rev/582be9aca672

What is the expected output?
no memory leak warnings in MacroExpand

What do you see instead?
warnings that "in" is leaked

What version of the product are you using?
r367

On what operating system?
Linux with Coverity 4.5

Please provide any additional information below.
The patch here tries to handle two distinct cases:
* early failure by arg scanning (before in-> is filled)
* later failure after in->args[] is filled (in two similar blocks, by 
refactoring)

Note that the I'm not adding code to handle failure to allocate in->args from 
malloc(). The code also seems to have a random mix of tabs and spaces. I tried 
to follow style or at least not rewrite the file.

Original issue reported on code.google.com by timel...@gmail.com on 12 Oct 2010 at 4:53

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by alokp@chromium.org on 9 Nov 2010 at 9:50

GoogleCodeExporter commented 9 years ago
The old preprocessor has been replaced with a completely rewritten one.  This 
issue should no longer be a problem. 

Original comment by dan...@transgaming.com on 26 Oct 2012 at 7:28