search

oja / amazon-music-linux

linux desktop player for amazon music
Mozilla Public License 2.0
46 stars 16 forks source link

Keyboard shortcuts #22

Open friimaind opened 5 years ago

friimaind commented 5 years ago

First of all thanks for this app :)

I'm using Ubuntu 18.04 (Gnome) and I would like to know if it's possible to integrate the classic play/pause keyboard's shortcuts (for example like official Spotify's client).

Thank you!

friimaind commented 5 years ago

EDIT: sorry, maybe my issue is a duplicate for this one https://github.com/oja/amazon-music-linux/issues/21

flokol120 commented 5 years ago

Hi @friimaind. Could you be more specific, which keyboard shortcuts you are referring to? I've never used Spotify.

friimaind commented 5 years ago

Hi @flokol120 , sure! I have a simple multimedia keyboard like this one: image

As you can see there are some buttons like play, pause, volume up/down, next/prev On my Gnome this buttons can control applications like Rhythmbox, Spotify etc..

I think that yebo29 opened a more specific issue on this https://github.com/oja/amazon-music-linux/issues/21 referring to D-Bus MRPIS's support

flokol120 commented 5 years ago

@friimaind thanks for the clarification. I will try to take a look at this as soon as I have some free time.

ofalk commented 5 years ago

Hi! I'd also love to see keyboard shortcuts working. If the executable would support command line options, that would already do the trick (for me), since I could map the keyboard shortcuts (known to work in Gnome or XFCE) to execute the binary with eg. --play/--pause/--forward/--back (or similar).

flokol120 commented 5 years ago

First off, thank you for the interest in this project, @ofalk. Currently I am pretty busy learning for my last, big school exam which is why I will not be able to contribute much during this time. Would it be an option if you would be able to reassign those keys in the settings? Is this even possible with those kinds of keys? Do you have any answers to those questions, @friimaind?

ofalk commented 5 years ago

@flokol120 Thanks for writing that piece of code!!

Yes, it's possible to reassign those keys in the settings - usually; As stated, at least in my setups (Fedora with XFCE + Gnome) this works fine.

The problem is: We need some kind of command line options and I'm not aware there are any!?

Thx!

flokol120 commented 5 years ago

@ofalk okay, thanks for the quick answer. Then I would prefer to add a section in the existing settings to assign additional keys to the play/pause, next and previous actions. I personally prefer the GUI-way but if you want a cli option that would also be possible as soon as the base functionality is written.

ofalk commented 5 years ago

Is there already in the GUI to assign keyboard shortcuts?! Am I using an older version!? Regarding command line options, any hints on where to start?

flokol120 commented 5 years ago

@ofalk no there is not yet, but I would implement such as soon as I got some free time.

ofalk commented 5 years ago

@flokol120 Thanks. I'm afraid, but since it's Node, I better not even try to get to read the source code too much. That's simply not my world. With C(++), Perl, Python, I could have offered to help. :smile: