Open ojacquemart opened 7 years ago
@ojacquemart I'll take this one too!
@ojacquemart could you also add a Hacktoberfest label too? 😃
Done :) but I don't know how it could be done in the UI.
Be inventive :)
@ojacquemart I did some research, and there appears to be a real time V'lille API. We should use this in order to get the most up to date station information. I don't think we should rename the actual stations, but rather let's rename favorites! That way we only modify user-owned data. What do you think?
@paynemiller92 The app already uses the api you mention :+1: The api is pretty good. See VlilleService
I am ok with your proposal. An user should only rename its favorite stations. The edit feature could be accessible at the click of an entry in the list in the StationInfoActivity. WDYT?
@ojacquemart I was actually thinking you could do it with a Swipe Menu. Inside the list/recycler view, have a swipeable menu that has both delete and edit options!
@paynemiller92 Good idea :+1:
@ojacquemart do you by chance have an API Key
that I may borrow? I see where you expect a system variable to have it inside the Gradle file. I also don't really wanna sign up for my own key since I live here in the states!
buildTypes.each {
it.buildConfigField 'String', 'OPENDATA_MEL_APIKEY', "\"$System.env.OPENDATA_MEL_APIKEY\""
}
@paynemiller92 ???
here is the dev api key :key: . Make good use of it!
It's an user's request: https://play.google.com/apps/publish/?account=9028326648516746972#ReviewDetailsPlace:p=com.vlille.checker&reviewid=gp:AOqpTOHcG9tdbD5R5wP981uiMLwp_GO6bp-QIXDsPYITMSqsq5vzmEXpWMGMhu3F5Dtqsiyrmsxz0_RITXX28A
It could be useful to rename a station.