search

ojacques / mkdocs-git-committers-plugin-2

MkDocs plugin for displaying a list of GitHub (.com or Enterprise) contributors on each page. Encourages contributions to the documentation!
MIT License
48 stars 15 forks source link

GitHub Enterprise disaplays no avatars #58

Open mihaigalos opened 1 week ago

mihaigalos commented 1 week ago

Using GH Enterprise, my user's avatar's URL is correctly fetched from the repo's commit, containing something like:

https://avatars.company.com/u/8554\?\&size\=72

This is ok, since an auth_header is used. But when dynamically resolving the src for the image, no auth is used and the avatar is not displayed, since the URL is not authorized:

Screenshot 2024-06-15 at 16 14 04

I think this is a missing feature for auth, or the plugin may need to potentially download the avatar as an asset in the .cache folder and serve it from there.

I'm using this config:

plugins:
  - git-committers:
      enterprise_hostname: company.com
      repository: orga/repo
      api_version: v3
      branch: main
mihaigalos commented 1 week ago

I know this is an authentication problem, because if I:

curl -sSLk https://avatars.company.com/8554\?\&size\=72

I get a "please login" page.