ojalaquellueva / TNRSapi

API wrapper for TNRS batch application
Other
4 stars 2 forks source link

API call 'syn' returns no results for some names with many synonyms #12

Closed ojalaquellueva closed 4 months ago

ojalaquellueva commented 4 months ago

API synonym request (mode='syn') for name="Pinus ponderosa" returns 12 synonyms when source "wfo" used, but nothing when source "wcvp" used.

Checking the original sources online, the synonyms returned by WFO (above) link directly to "Pinus ponderosa", whereas in Plants of the World Online (wcvp), they link to subspecies of Pinus ponderosa. Therefore, SQL must be modified to return synonyms of accepted subspecies/varieties/formas of the species submitted, in addition to the species itself.

ojalaquellueva commented 4 months ago

Also note that this happens for accepted names which have no synonyms. It is important to return a response. To replicate, submit name="Ticodendron incognitum", source="wcvp".

ojalaquellueva commented 4 months ago

Expanded SQL to include synonyms of accepted infraspecific taxa of submitted name.