search

ojarva / python-ledcontroller

Controller library for limitlessled/easybulb/milight Wi-Fi LEDs
BSD 3-Clause "New" or "Revised" License
35 stars 9 forks source link

Allow for raw hue values to be set #5

Closed McSwindler closed 8 years ago

McSwindler commented 9 years ago

I wanted to be a little more versatile in my color selections, it uses the same set_color method, but instead of being limited to a named color you can use an int from 0-255

happyleavesaoc commented 8 years ago

Any chance this gets merged in?

ojarva commented 8 years ago

@happyleavesaoc with tests failing, no. If someone fixes the tests (and preferably updates the docs as well), I'll happily merge this.

ojarva commented 8 years ago

@happyleavesaoc @McSwindler I'll close this pull request, as in the end I implemented the same functionality in 437db258a560a4530738b359f160e2b31a2bebd1 , but with some improvements (checks for values, python2 compatibility, more comprehensive tests).