search

ojasaklechayt / Music-Streaming-App

Music Streaming App MERN App
https://groovewave.vercel.app
Creative Commons Zero v1.0 Universal
13 stars 18 forks source link

[feat] [client] Adding-toast-notifications #30

Closed Sameersawant77 closed 12 months ago

Sameersawant77 commented 12 months ago

closes #18

Added toast notifications for successful login and registration or error while authenticating ^^ npm i to download the toastify node package

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
groovewave ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 5:31pm
ojasaklechayt commented 12 months ago

@Sameersawant77 Thankyou for the PR. I would like to add on into it that can you please specify the toster which is been shown. Like if password is not entered, it should display password not display, or if the password is not correct, it can show wrong password added or if email format is not correct then it can show wrong email format etc etc. same goes for the registration page.

Sameersawant77 commented 12 months ago

Hey @ojasaklechayt, sure i can the requirements provided the API response passes a message depending on the error

ojasaklechayt commented 12 months ago

Hey @ojasaklechayt, sure i can the requirements provided the API response passes a message depending on the error

You can check the backend code, I feel the response for wrong password is not there, may you can add up that condition in the backend.

Sameersawant77 commented 12 months ago

@ojasaklechayt I have added toast notifications "user not found" and "invalid password" for login and "User already exists" while signup ^^

ojasaklechayt commented 12 months ago

@Sameersawant77 Great work Sameer, Thanks for the contribution ^^^