search

ojasaklechayt / Oju-s-Blogs

A full MERN Stack Blogging website to write out yourself
https://oju-blogs.vercel.app
10 stars 14 forks source link

Bug : Problem in signup #29

Open yube01 opened 10 months ago

yube01 commented 10 months ago

At the time of sign up when I enter strong password with more than 10 words it stills shows enter strong password

ojasaklechayt commented 10 months ago

@Pooja-Lohar25 what do you think about this ?

Pooja-Lohar25 commented 10 months ago

@yube01 Thanks for the lookup, may i know the exact string that showed this error, because a string having just a length of more than 10 characters isn't a strong password.

the code accepts the usual pattern of a strong password as follows : password should have atleast

  1. 1 uppercase
  2. 1 lowercase
  3. 1 digit
  4. 1 special character
  5. length = 8 or more

@ojasaklechayt We can add these guidelines in the UI if required.

ojasaklechayt commented 10 months ago

@yube01 May i know the exact string that showed this error, because a string having just a length of more than 10 characters isn't a strong password.

the code accepts the usual pattern of a strong password as follows : password should have atleast

  1. 1 uppercase
  2. 1 lowercase
  3. 1 digit
  4. 1 special character 5.. length = 8 or more

we can add these guidelines in the UI if required.

I think it would be great if we can have the instructions in the UI. But let's see what is the key @yube01 tried to give

yube01 commented 10 months ago

Is there any kind of validation in password??

Pooja-Lohar25 commented 10 months ago

Is there any kind of validation in password??

yes it only accepts strong passwords as valid passwords or else produces error.

@yube01 please mention what kind of string produced the error so that the bug can be fixed if it exists.

yube01 commented 10 months ago

Oh sorry I didn't know about that validation

ojasaklechayt commented 10 months ago

@Pooja-Lohar25 I feel it would be great it we can update the conditions of strong password in the UI.

rnavaneeth992 commented 7 months ago

I want to work on this issue

ojasaklechayt commented 7 months ago

I want to work on this issue

go for it

rnavaneeth992 commented 7 months ago

@ojasaklechayt One doubt this repo comes under toc winter right?

ojasaklechayt commented 7 months ago

@ojasaklechayt One doubt this repo comes under toc winter right?

Yes

rnavaneeth992 commented 7 months ago

@ojasaklechayt I created PR Can you check and update