ojedaf / vCLIMB_Benchmark

28 stars 3 forks source link

Use of Validation Set for Creation of the Memory Set #7

Closed yashika-git closed 10 months ago

yashika-git commented 10 months ago

Hello @ojedaf,

Thanks for creating the vCLIMB Benchmark and for also providing the code. It's been really helpful.

I came across something in the code, specifically in the main_icarl_conLoss.py file, around line 214 (here). I noticed that the validation set is being used to create the exemplar set (the memory).

I was curious about the choice of using the validation set here. Is there a particular reason for this, or should we consider using the training set to create the memory?

Thank you!

ojedaf commented 10 months ago

Dear @yashika-git,

Thank you very much for your interest in our work. As seen in Line 214, the data (data parameter) used to fill the memory is from the training set for the current task (please see Line 201). We use val_cilDatasetList to create the dataloader using the validation data transformations to select the relevant videos to save into the memory.

Best, AV