search

ojengwa / django-tagging

Automatically exported from code.google.com/p/django-tagging
Other
1 stars 0 forks source link

Fix signal to Signals refactory made in Django #144

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The revision 8223 (of Django) came with lots of changes in the signals
system, and to adapt to them we must declare a "**kwargs" argment to signal
functions.

Original issue reported on code.google.com by mari...@gmail.com on 6 Aug 2008 at 5:41

GoogleCodeExporter commented 9 years ago 
Done

Original comment by mari...@gmail.com on 6 Aug 2008 at 5:41

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you for your patch.  I'm able to run without errors now, but I still get 
the following warning:

DeprecationWarning: dispatcher.connect() is deprecated; use Signal.connect() 
instead.
  dispatcher.connect(self._save, signal=signals.post_save, sender=cls)

I'm not familiar with with signals, but hopefully someone could add a fix to 
the patch.

Original comment by michaelg...@gmail.com on 6 Aug 2008 at 6:16

GoogleCodeExporter commented 9 years ago 
change line 33 of fields.py to:

signals.post_save.connect(self._save, sender=cls)

Original comment by fig...@gmail.com on 6 Aug 2008 at 6:52

GoogleCodeExporter commented 9 years ago 
No warnings now!  Thank you!

Original comment by michaelg...@gmail.com on 6 Aug 2008 at 6:54

GoogleCodeExporter commented 9 years ago 
here is another version of this same patch...  hope to see something 
incorporated soon....  note this patch also 
fixes another issue with newforms being deprecated in another module.

Original comment by palt...@gmail.com on 7 Aug 2008 at 2:13

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patch

Original comment by redsnapp...@gmail.com on 7 Aug 2008 at 1:31

GoogleCodeExporter commented 9 years ago 
I wrote same patch :-) now I see that people made it 43 hours ago. Since not yet
incorporated, have to svn export django tagging for now...

Original comment by alex.v.k...@gmail.com on 8 Aug 2008 at 1:03

GoogleCodeExporter commented 9 years ago 
I second this diff. I made a patch file myself, only to find someone else 
already did it.
Notice how mine is the same!

Original comment by natmas...@gmail.com on 11 Aug 2008 at 5:53

Attachments:

GoogleCodeExporter commented 9 years ago 
Guyssss... wake up :)

Original comment by ppr.vit...@gmail.com on 11 Aug 2008 at 7:50

GoogleCodeExporter commented 9 years ago 
Fixed in r141. Thanks for the Patch!

Original comment by doug.nap...@gmail.com on 11 Aug 2008 at 7:09