search

ojkelly / yarn.build

Build 🛠 and Bundle 📦 your local workspaces. Like Bazel, Buck, Pants and Please but for Yarn Berry. Build any language, mix javascript, typescript, golang and more in one polyglot repo. Ship your bundles to AWS Lambda, Docker, or any nodejs runtime.
https://yarn.BUILD
MIT License
325 stars 28 forks source link

Make formatHeader handle deeply nested tree #254

Closed ulrik-s closed 1 year ago

ulrik-s commented 1 year ago

When formatHeader function was called in a project with a deep structure the calculation of how many minus-signs that should be printed in the report header could become negative. This negative value was fed into the string repetition method causing an exception to be thrown.

This change rewrites and hardens the formatHeader function.

ojkelly commented 1 year ago

Thanks for the fix, I'm re-running the checks (netlify was using an old base image) so we can merge this.

ulrik-s commented 1 year ago

Thanks for a great plugin our build times has been dramatically reduced, so I am really keen on getting this patch in. There still seems to be some failing checks and I am not sure what I can do to fix them. Let me know if there is anything further you want from me.

ojkelly commented 1 year ago

Thanks for this fix @ulrik-s. Sorry for the delay on getting it into a release, I've been heads down working on gold.build.