ojo / ios

:iphone:
0 stars 0 forks source link

iOS 9: Stations3VC Doesn't adjust layout after popupItem appears #53

Open btc opened 7 years ago

btc commented 7 years ago

viewDidLayoutSubviews fires, but the bottomLayoutGuide doesn't change

btc commented 7 years ago

@LeoNatan I am able to produce LNPopupController/Issue/131 in this project. It occurs on 9.3 both on an iPhone 5 and in the simulator (iPhone 5). If you build this project, you can see it in action.

Please see attached video: glitch.zip

LeoNatan commented 7 years ago

Does it only occur on iPhone 5? I haven't tested on that. Does it occur on SE as well?

btc commented 7 years ago

I haven't tested the 9.3 iPhone 6 or iPhone 7 combination. Let me try that now.

LeoNatan commented 7 years ago

Specifically, please test iPhone SE on iOS 9.3.

btc commented 7 years ago

Reproduced:

image

LeoNatan commented 7 years ago

Ahh I think I know what the problem is. Did you set the tab bar as not translucent? I think I've seen this in the past and tried to debug the issue, and it was a big mess.

As a workaround, try making your bar translucent, but if you prefer to have it white, set the background color to white.

btc commented 7 years ago

I didn't change the tab bar to be not translucent. See: https://github.com/ojo/ios/blob/master/ojo/UITabBarRootViewController.swift

It probably just looks that way because there's nothing behind it.

LeoNatan commented 7 years ago

Let me run the app and see. Does it require any special setup, such as login?

LeoNatan commented 7 years ago

What is "bundle"? And oh no, you are using CocoaPods! Terrible 😢

btc commented 7 years ago

If you notice, I use Carthage wherever I can. I only use Cocoapods because Firebase Cloud Messaging is only distributed through pods. =(

It's makes me really sad to have to use Cocoapods. I don't like. Yuck.

btc commented 7 years ago

No special setup. Just what you see in the README

LeoNatan commented 7 years ago

I don't know what bundle is.

btc commented 7 years ago

bundle is just to install Cocoapods in a local environment. If you already have Cocoapods, you can skip that step.

btc commented 7 years ago

You can just run pod install

LeoNatan commented 7 years ago

Cool. Yes, Google insists on using CocoaPods due to iOS 7 support. Stupid.

LeoNatan commented 7 years ago
screen shot 2017-01-04 at 21 37 31

Swift = terrible I can't run your project, because my Xcode is 8.2, and I have Swift 3.0.2, but alas, the Swift framework was compiled using Swift 3.0.0. No ABI. "Apple, it just works"

btc commented 7 years ago

Did you include --no-use-binaries when you installed deps with Carthage? I ran into that issue when I didn't include that flag in Carthage's bootstrap/update step.

LeoNatan commented 7 years ago

Oh, I didn't. Anyway, I will not have time today. Maybe over the weekend.

btc commented 7 years ago

@LeoNatan There's a chance this is an iOS 9 OS bug, huh?

LeoNatan commented 7 years ago

There is a good chance it is, especially if working in 10+. But I still want to take a look.

LeoNatan commented 7 years ago

Bear with me, will take a look soon.