Closed tunix closed 3 years ago
I'd rather have the change in partials/footer.html just to be consistent with where other margins where set. Can you add "mt-5" there?
I see. The problem with that is the footer being optional. I don't use a footer on my site and so this fix wouldn't work for me. To keep the footer optional, I've added an empty block with class mb-5
. What do you think?
I didn't want to add another commit so forced the existing one which seems not a good idea for github's workflow. :) Sorry for that.
Example from my site without a footer:
Example with the footer:
The aim is to have the same amount of margin at the top of the page to exist at the bottom as well.
The lack of the bottom margin is very noticible when using a mobile device. 🙂